68f365cddb
apply mwm hints later
okan
2013-12-11 15:46:47 +00:00
7e0749b0b1
Add client wrapper for XWMHints to support XA_WM_HINTS in PropertyNotify events; based off a diff from Thomas Adam.
okan
2013-12-11 15:41:11 +00:00
0d9b1becff
Remove extra work and simplify client state handling.
okan
2013-12-11 14:16:09 +00:00
23a1abdd8a
Stash Class and WM Hints in client_ctx
okan
2013-12-11 14:09:21 +00:00
1d68f0683a
Redraw client border when unhiding; during a hide, we just unset the active flag but never redraw since it'll be in IconicState.
okan
2013-12-10 21:27:37 +00:00
7fad5224d4
If not using sticky mode (the default), clients aren't automagically assigned a group, thus cc->group will be NULL - fix the client group shortcut in menu lists; crash reported by Christian Neukirchen.
okan
2013-12-08 13:51:38 +00:00
27513daee2
Revert "use u_char for buffers in yylex"
Christian Neukirchen
2013-12-06 23:16:54 +01:00
5dc65d9242
When we receive a NotionNotify event, there's no need to (incorrectly might I add) redraw the top menu selection.
okan
2013-12-02 20:01:19 +00:00
161ed1801a
Always highlight the first menu item (helpful to see selected items when not using a mouse and therefore not generating Expose/MotionNotify events); from Thomas Adam.
okan
2013-12-02 19:49:26 +00:00
d1b232fe81
Prepend the group shortcut in the client search menu; from Thomas Adam. Likewise, prepend shortcut in unhide menu.
okan
2013-12-02 19:30:27 +00:00
6b72168d92
Since we use IconicState as our hidden state, check for the hidden flag and unmanage the client if we're not hidden (basically if NormalState) during an UnmapNotify event.
okan
2013-12-02 14:30:12 +00:00
5e67a12262
like gap, make snapdist per screen
okan
2013-11-27 18:34:34 +00:00
1b6ef8e9ed
alter -r1.145 getsizehints to deal with clients that don't have WM_NORMAL_HINTS.
okan
2013-11-27 17:04:35 +00:00
abf52049b9
Remove the option to bind a key by keycode with brackets; it never worked (and no one complained!). While it's fairly easy to fix, users should be using keysym names and not keycodes.
okan
2013-11-27 16:24:17 +00:00
fa25915a75
Rewrite active/inactive client handling in client_setactive(); client_leave() served no real purpose, likewise no reason to handle LeaveNotify events since an EnterNotify will process the next active client (and we don't have anything important to process anyway), so xev_handle_leavenotify() goes as well. Allows a simplification of client_mtf() and client_cycle_leave() for clarity. While here, unify a few client_current() checks.
okan
2013-11-27 00:01:23 +00:00
03b19f1487
Log message: use u_char for buffers in yylex, for ctype calls, as done in all other parse.y in the tree found by millert@, ok okan@
benno
2013-11-25 18:21:55 +00:00
2937b2066f
Alter the r1.35 of event.c race fix. Remove the forward looking event queue check (removing the need for a server grab/ungrab) - if the client is going away, let it fall all the way through to a DestroyNotify event. There's no longer a need for us to manually destroy a client ourselves (removing yet another server grab/ungrab). Instead, when the UnmapNotify event is synthetic, simply set the state to Withdrawn (as per ICCCM), else Iconic (in our case 'hidden').
okan
2013-11-12 21:25:00 +00:00
bda68b0924
Put back the border draw call in client_resize; since we are adding and removing the border on maximized clients we need to redraw.
okan
2013-11-11 12:51:15 +00:00
3bb928a1c2
stash WMProtocols in flags
okan
2013-11-08 17:35:12 +00:00
c1bc6d37b3
quick keyboard focus fix for clients that neither populate wmhints nor wmprotocols, like rdesktop; focus needs to be re-visited
okan
2013-11-05 00:55:42 +00:00
b5915eb989
The only reason we need to keep XSizeHints in our client_ctx is for flags, so just add one to hints; consolidates sizehints and shrinks. Additionally don't abuse PSize for XGetWMNormalHints() failures.
okan
2013-11-02 19:13:56 +00:00
b8f53666bd
x/y from XSizeHints are obsolete (and have been for a long time), so instead use x/y from XWindowAttributes when USPosition|PPosition are set.
okan
2013-11-01 21:54:20 +00:00
06eb13dfd9
re-add support for WM_TAKE_FOCUS, and additionally this time only call XSetInputFocus() for clients that have the InputHint; latter fix discovered by Valery Masiutsin with a PoC patch - solves keyboard input focus loss for java apps.
okan
2013-11-01 14:07:19 +00:00
6e17b41f56
A client_delete should behave differently depending on whether the triggering event was unmap (with pending destroy) log destroy; we only need to grab/ungrab the server lock, set WithdrawnState and XRemoveFromSaveSet clients coming from an unmap event - doing so for clients coming from destroy are already gone, hence we generate errors.
okan
2013-10-25 19:46:16 +00:00
5b733a152d
wrap key ungrab like btn ungrab, for it'll be used again
okan
2013-10-20 01:55:32 +00:00
9ff288baef
revert 1.138 (WM_TAKE_FOCUS) for now
okan
2013-10-20 01:35:47 +00:00
a2013ee9dd
Using xu_btn_ungrab() buttons during client_leave doesn't work (error BadValue) when the modifier is already AnyModifier . Instead alter xu_btn_ungrab() to ungrab AnyButton/AnyModifier and call it only when a client is coming into focus in client_setactive(), instead of iterating over ignore mods - matches how we handle key grabs.
okan
2013-10-19 19:39:34 +00:00
083a023f2c
I believe we redraw the border in too many cases; likely a leftover from the cc->pwin days - don't redraw on every unhide, resize, and mouse move/resize Expose event (note, all Expose events trigger a redraw anyway).
okan
2013-10-19 18:59:22 +00:00
a70b2d81af
For clients that support WM_TAKE_FOCUS in their WM_PROTOCOLS property, send a ClientMessage event.
okan
2013-10-19 00:24:54 +00:00
a88b8c1363
a few err->errx since we don't have error messages here; from Tiago Cunha
okan
2013-10-17 13:59:10 +00:00
0d6e8a9146
Makefile: rm -f is enough
Christian Neukirchen
2013-10-16 23:05:51 +02:00
bd7b8163bb
bring buttonpress and keypress event handlers slightly closer together
okan
2013-07-10 14:15:58 +00:00
9571038358
type fixes
okan
2013-07-10 14:11:42 +00:00
dd10412804
since the root and event window are the same in the case of a button event on the screen's root window, there's no need to pass down the entire XButtonEvent event, at least to group_menu(), the only callback which takes an argument at this point; instead use the already populated screen.
okan
2013-07-09 01:24:49 +00:00
9bf2498d7e
add support for mouse based group {,r}cycle; from Rodrigo Mosconi. not bound by default.
okan
2013-07-08 18:39:20 +00:00
1f244fe29c
move kbfunc and mousefunc closer together
okan
2013-07-08 18:19:22 +00:00
a493734066
clarify kbd vs mouse functions
okan
2013-07-08 16:32:51 +00:00
912ec90ea1
move duplicate kbd and mouse modifier parsing to a generic function; from Tiago Cunha
okan
2013-07-08 16:10:55 +00:00
fe439f2b96
replace a few (x)malloc with (x)calloc to prevent potential integer overflows; from Tiago Cunha
okan
2013-07-08 15:48:16 +00:00
7a7e5cd592
whitespace and style fixes; from Tiago Cunha and one from me.
okan
2013-07-08 15:46:16 +00:00
7004700ce0
when selfont is configured, make sure we continue and configure the rest of the screen (quick fix); discovered the hard way by Rodrigo Mosconi.
okan
2013-06-20 02:33:57 +00:00
234b8214df
move Cursors into conf.
okan
2013-06-17 17:11:10 +00:00
23d84adb5e
now that we have conf_screen, which configures individual screens *after* config parsing, we no longer need to split up display/screen initialization, so collapse.
okan
2013-06-17 14:08:51 +00:00
8b00f438be
allow mouse button4 and button5; from Rodrigo Mosconi
okan
2013-06-17 00:57:47 +00:00
6059073a5f
move synthetic responses and have client_msg only work with WM_PROTOCOLS, since that's all ClientMessageEvent is for anyway.
okan
2013-06-10 21:37:30 +00:00
b365ceac0e
Check for, and honour, CWStackMode and CWSibling change requests during a ConfigureRequest event. Additionally, honour a border width change; detailed report and patch from Mike Small.
okan
2013-06-10 20:11:43 +00:00
09f3275561
Unlike other parse.y variants, cwm's allowed 'command xx /path/to/xx' without quotes. Reinstate this support lost in recent sync diff and add a comment to show that it's intentional. ok okan@
sthen
2013-06-03 20:33:17 +00:00
5515a365ba
cvsimport
Christian Neukirchen
2013-05-29 22:37:37 +02:00
692d341dfc
fix type in a ClientMessage (xu_sendmsg).
okan
2013-05-27 23:20:45 +00:00
be1a7a3f5c
alter conf_grab(_kbd) to first ungrab AnyKey/AnyModifier, then proceed to grab keys in keybindingq. we don't need to ungrab/grab on every addition to the queue, just once with a complete keybindingq; simplify grabbing keys per screen (during init) and during a MappingNotify.
okan
2013-05-23 16:52:39 +00:00
7cc1c7344f
since we don't have any screens yet, there's no reason to conf_{,un}grab here; just build keybindingq.
okan
2013-05-22 20:23:21 +00:00
d1eadee922
get rid of long standing XXX: now that we configure screens based on config options, add the keybinding GrabKey calls here
okan
2013-05-22 16:54:09 +00:00
532f132194
move validation of pointer Button into conf_mousebind so we check validity during the parse phase and not bother adding it to the queue, instead of each time a client needs to grab (when it's too late); furthermore, make this a config error, stop parsing and load the default config.
okan
2013-05-22 16:32:15 +00:00
866f5af9c7
sync with src changes
okan
2013-05-22 13:02:14 +00:00
421bf22ac7
handle _NET_WM_STATE ClientMessage; from Alexander Polakov.
okan
2013-05-21 00:29:20 +00:00
ad8020e17d
handle _NET_ACTIVE_WINDOW ClientMessage; from Alexander Polakov.
okan
2013-05-20 21:19:15 +00:00
284af4ca0c
add support for _NET_WM_STATE_MAXIMIZED_{HORZ,VERT}; from Alexander Polakov.
okan
2013-05-20 21:13:58 +00:00
270df196ac
- configure menuwin with the screen, then create the xft drawable using the menu window since that's the only place on which we draw - elminate the need to change the drawable on every font draw
okan
2013-05-20 20:21:04 +00:00
e14123210a
no reason to pass around *sc when it's already in menu_ctx.
okan
2013-05-20 20:04:36 +00:00
5b4c55616a
move the 2 small font helper functions to xutil.c
okan
2013-05-19 23:38:20 +00:00
e41c84c752
move the rest of xft init into screen_conf, since most of it is based on config parameters.
okan
2013-05-19 23:16:29 +00:00
dac00a232f
- switch border colors to Xft - merge border/menu color structures/functions since they now both use Xft - switch xu_xorcolor to operating on XftColor instead of just XRenderColor (basically adding pixel) - if color name allocation fails, revert back to default (this, along with font validation should occur during config parse, but we don't have screens setup yet - likely to change at some point)
okan
2013-05-19 23:09:59 +00:00
c84145661e
add support for _NET_CLOSE_WINDOW
okan
2013-05-19 17:05:52 +00:00
556a50d8f7
treat WM_CHANGE_STATE like other atoms
okan
2013-05-19 17:03:55 +00:00
01bfdd7b42
use XGetWMProtocols and simplify WM_PROTOCOL handling
okan
2013-05-19 17:02:04 +00:00
be72620432
if -> ifdef
okan
2013-05-14 13:39:53 +00:00
c637a54048
- let callers of font_draw figure out (and pass) the color instead of an 'active' flag. - use strlen() inside of font_draw; the only instance where it wasn't used happened to be ignored on a subsequent draw.
okan
2013-05-14 12:35:56 +00:00
112f616d1d
swap x/y calculations in kbd move/resize to match those in the respective mouse functions
okan
2013-05-11 22:03:17 +00:00
2b926784ba
new -> init
okan
2013-05-11 22:01:07 +00:00
3a38686137
replace conf_{gap,color,font} with conf_screen since really we are configuring the screen *after* parsing, just as we do a conf_client on client manage.
okan
2013-05-11 21:46:27 +00:00
9b9e95d742
more type fixes for mask/button
okan
2013-05-10 16:32:47 +00:00
okan